Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compliance tests for environment variables #648

Merged

Conversation

yuktea
Copy link
Contributor

@yuktea yuktea commented Mar 31, 2022

Added integration tests to verify compliance with the specification matrix.
Covers:

OTEL_SPAN_ATTRIBUTE_VALUE_LENGTH_LIMIT
OTEL_SPAN_EVENT_COUNT_LIMIT
OTEL_SPAN_LINK_COUNT_LIMIT
OTEL_EVENT_ATTRIBUTE_COUNT_LIMIT
OTEL_LINK_ATTRIBUTE_COUNT_LIMIT

@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #648 (1e03a15) into main (ca05f51) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #648   +/-   ##
=========================================
  Coverage     84.45%   84.45%           
  Complexity     1141     1141           
=========================================
  Files           127      127           
  Lines          2766     2766           
=========================================
  Hits           2336     2336           
  Misses          430      430           
Flag Coverage Δ
7.4 84.40% <ø> (ø)
8.0 84.45% <ø> (ø)
8.1 84.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca05f51...1e03a15. Read the comment docs.

@yuktea yuktea marked this pull request as ready for review March 31, 2022 11:37
@yuktea yuktea marked this pull request as draft March 31, 2022 11:42
@yuktea yuktea marked this pull request as ready for review April 1, 2022 16:22
@tidal tidal merged commit f2ad2fc into open-telemetry:main Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants