Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example of how to create a new trace in same process #650

Merged
merged 1 commit into from
Apr 2, 2022

Conversation

tidal
Copy link
Member

@tidal tidal commented Apr 2, 2022

This PR adds a an example of how to create a new trace in the same process by resetting the scope/context.

@codecov
Copy link

codecov bot commented Apr 2, 2022

Codecov Report

Merging #650 (f57df81) into main (39c99e5) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #650      +/-   ##
============================================
- Coverage     84.46%   84.45%   -0.01%     
- Complexity     1140     1141       +1     
============================================
  Files           126      127       +1     
  Lines          2761     2766       +5     
============================================
+ Hits           2332     2336       +4     
- Misses          429      430       +1     
Flag Coverage Δ
7.4 84.40% <ø> (-0.01%) ⬇️
8.0 84.45% <ø> (-0.01%) ⬇️
8.1 84.45% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Contrib/OtlpGrpc/Exporter.php 90.00% <0.00%> (-1.53%) ⬇️
src/Contrib/Jaeger/SpanConverter.php 96.47% <0.00%> (-0.24%) ⬇️
src/Contrib/Jaeger/IdConverter.php 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39c99e5...f57df81. Read the comment docs.

@tidal
Copy link
Member Author

tidal commented Apr 2, 2022

Hmm, this is again showing some drop in code coverage for totally unrelated classes.
Maybe using the complete CI matrix as a key for the code coverage report will fix this?

@brettmc brettmc merged commit 5f71d3c into open-telemetry:main Apr 2, 2022
@tidal tidal deleted the new-trace-example branch April 2, 2022 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants