Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

static logging methods #651

Merged
merged 1 commit into from
Apr 2, 2022
Merged

static logging methods #651

merged 1 commit into from
Apr 2, 2022

Conversation

brettmc
Copy link
Collaborator

@brettmc brettmc commented Apr 2, 2022

allow logging methods in LogsMessagesTrait to be called from within either a static or non-static method.
in passing, adding a missing coversNothing annotation on a complaining integration test

allow logging methods in LogsMessagesTrait to be called from within either a static or non-static method.
in passing, adding a missing coversNothing annotation on a complaining integration test
@codecov
Copy link

codecov bot commented Apr 2, 2022

Codecov Report

Merging #651 (93c0bf0) into main (5f71d3c) will not change coverage.
The diff coverage is 94.73%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #651   +/-   ##
=========================================
  Coverage     84.27%   84.27%           
  Complexity     1146     1146           
=========================================
  Files           127      127           
  Lines          2772     2772           
=========================================
  Hits           2336     2336           
  Misses          436      436           
Flag Coverage Δ
7.4 84.21% <94.73%> (ø)
8.0 84.27% <94.73%> (ø)
8.1 84.27% <94.73%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Contrib/Jaeger/JaegerTransport.php 86.66% <0.00%> (ø)
src/Contrib/OtlpGrpc/Exporter.php 90.00% <100.00%> (ø)
src/SDK/Behavior/LogsMessagesTrait.php 100.00% <100.00%> (ø)
...rc/SDK/Trace/SpanProcessor/SimpleSpanProcessor.php 100.00% <100.00%> (ø)
src/SDK/Trace/TracerProviderFactory.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f71d3c...93c0bf0. Read the comment docs.

@bobstrecansky bobstrecansky merged commit 80a6d63 into open-telemetry:main Apr 2, 2022
@brettmc brettmc deleted the static-logging-methods branch April 2, 2022 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants