Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Error level of BC messages configurable and add info to README. #657

Merged
merged 6 commits into from
Apr 5, 2022

Conversation

tidal
Copy link
Member

@tidal tidal commented Apr 4, 2022

No description provided.

@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #657 (394b49a) into main (39c99e5) will decrease coverage by 0.18%.
The diff coverage is 87.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #657      +/-   ##
============================================
- Coverage     84.46%   84.27%   -0.19%     
- Complexity     1140     1152      +12     
============================================
  Files           126      127       +1     
  Lines          2761     2786      +25     
============================================
+ Hits           2332     2348      +16     
- Misses          429      438       +9     
Flag Coverage Δ
7.4 84.22% <87.50%> (-0.19%) ⬇️
8.0 84.27% <87.50%> (-0.19%) ⬇️
8.1 84.27% <87.50%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/SDK/Common/Dev/Compatibility/Util.php 92.59% <87.50%> (-7.41%) ⬇️
src/Contrib/OtlpGrpc/Exporter.php 90.00% <0.00%> (-1.53%) ⬇️
src/Contrib/Jaeger/SpanConverter.php 96.47% <0.00%> (-0.24%) ⬇️
src/SDK/Resource/ResourceInfoFactory.php 0.00% <0.00%> (ø)
src/Contrib/Jaeger/IdConverter.php 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39c99e5...394b49a. Read the comment docs.

Copy link
Collaborator

@brettmc brettmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with one comment to look at

@tidal tidal merged commit 99fba0d into open-telemetry:main Apr 5, 2022
@tidal tidal deleted the compat_level branch April 5, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants