Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored ResourceInfo and ResourceInfoFactory Unit and Integration tests #664

Conversation

kishannsangani
Copy link
Member

@kishannsangani kishannsangani commented Apr 20, 2022

Moved test functions belonging to ResourceInfoFactory out from ResourceInfoTest and moved some tests out from Unit test to Integration test.

Closes #629.

@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #664 (2d8efbc) into main (1d5283b) will increase coverage by 0.96%.
The diff coverage is n/a.

❗ Current head 2d8efbc differs from pull request most recent head 1082a47. Consider uploading reports for the commit 1082a47 to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #664      +/-   ##
============================================
+ Coverage     84.28%   85.25%   +0.96%     
  Complexity     1153     1153              
============================================
  Files           128      128              
  Lines          2788     2788              
============================================
+ Hits           2350     2377      +27     
+ Misses          438      411      -27     
Flag Coverage Δ
7.4 85.20% <ø> (+0.97%) ⬆️
8.0 85.25% <ø> (+0.96%) ⬆️
8.1 85.25% <ø> (+0.96%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/SDK/Resource/ResourceInfoFactory.php 60.00% <0.00%> (+60.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d5283b...1082a47. Read the comment docs.

@bobstrecansky bobstrecansky merged commit 5de0986 into open-telemetry:main Apr 20, 2022
@kishannsangani kishannsangani deleted the refactor_resourceinfofactory_tests branch May 25, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor ResourceInfo tests
3 participants