Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add phpunit annotations for compliance tests #670

Merged
merged 2 commits into from
May 6, 2022

Conversation

yuktea
Copy link
Contributor

@yuktea yuktea commented May 4, 2022

Possible spec matrix changes:

  • Associate Tracer with InstrumentationScope

  • Default value for service.name

yuktea added 2 commits May 7, 2022 03:09
Had to re-run `make style`, somehow missed a spot.
@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #670 (fee9b01) into main (8ae46f2) will increase coverage by 0.78%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #670      +/-   ##
============================================
+ Coverage     85.28%   86.07%   +0.78%     
  Complexity     1151     1151              
============================================
  Files           128      128              
  Lines          2794     2794              
============================================
+ Hits           2383     2405      +22     
+ Misses          411      389      -22     
Flag Coverage Δ
7.4 86.03% <ø> (+0.79%) ⬆️
8.0 86.07% <ø> (+0.78%) ⬆️
8.1 86.07% <ø> (+0.78%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Context/Context.php 82.92% <0.00%> (+7.31%) ⬆️
src/API/Trace/AbstractSpan.php 38.88% <0.00%> (+38.88%) ⬆️
src/SDK/Trace/SpanLimits.php 75.00% <0.00%> (+75.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ae46f2...fee9b01. Read the comment docs.

@yuktea yuktea marked this pull request as ready for review May 6, 2022 21:45
@yuktea
Copy link
Contributor Author

yuktea commented May 6, 2022

Rebased and good to go!

@brettmc brettmc merged commit 25cfcfb into open-telemetry:main May 6, 2022
@yuktea yuktea deleted the phpunit-annotations branch June 2, 2022 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants