Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the base docker image to w3c context validation tests #673

Merged
merged 1 commit into from
May 6, 2022

Conversation

yuktea
Copy link
Contributor

@yuktea yuktea commented May 6, 2022

To speed up the test setup, the base docker image is put to use in the docker-compose file for W3C trace-context validation tests .
A part of Issue #589

Use the base docker image in the docker-compose file of the W3C context
validation tests to speed up the test set up
@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #673 (8b96423) into main (4592a27) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #673      +/-   ##
============================================
+ Coverage     85.26%   85.28%   +0.02%     
+ Complexity     1153     1151       -2     
============================================
  Files           128      128              
  Lines          2789     2794       +5     
============================================
+ Hits           2378     2383       +5     
  Misses          411      411              
Flag Coverage Δ
7.4 85.24% <ø> (+0.02%) ⬆️
8.0 85.28% <ø> (+0.02%) ⬆️
8.1 85.28% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/SDK/Trace/Span.php 93.91% <0.00%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4592a27...8b96423. Read the comment docs.

@yuktea yuktea marked this pull request as ready for review May 6, 2022 22:34
@brettmc brettmc merged commit 85282b5 into open-telemetry:main May 6, 2022
@yuktea yuktea deleted the base-docker-image-w3c-tests branch June 2, 2022 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants