Update framework integration docs #689
Conversation
yuktea
requested review from
bobstrecansky,
zsistla,
tidal and
brettmc
as code owners
Codecov Report
@@ Coverage Diff @@
## main #689 +/- ##
=========================================
Coverage 85.00% 85.00%
Complexity 1233 1233
=========================================
Files 137 137
Lines 2980 2980
=========================================
Hits 2533 2533
Misses 447 447
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
- Avoid multiple constructor calls. - Grammar regression. - Fix type `s/jaegar/jaeger`.
|
@bobstrecansky should be okay to merge? |
yuktea
force-pushed
the
update-integration-docs
branch
from
bbec4c9
to
ff384bb
Compare
docs/laravel-integration.md
Outdated
| try { | ||
| throw new \Exception('Exception Example'); | ||
| } catch (\Exception $exception) { | ||
| $span->setSpanStatus($exception->getCode(), $exception->getMessage()); | ||
| $childSpan->setSpanStatus($exception->getCode(), $exception->getMessage()); |
There was a problem hiding this comment.
Span::setStatus() accepts StatusCode::STATUS_* now, and this should now use Span::recordException. See SpanInterface
There was a problem hiding this comment.
Should we still set a status or only record the exception without marking the error status?
|
Perhaps a good naming convention would be:
|
Updates Laravel and Symfony integration docs for consistency with API changes, correctness and completeness. Also fixes some language and fixes the md styling.