Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition W3C Trace Context Test Service to Vanilla PHP #695

Merged

Conversation

yuktea
Copy link
Contributor

@yuktea yuktea commented Jun 2, 2022

What

Transitions the w3c-trace-context test to vanilla PHP.

Why

Speed and simplicity.

@yuktea yuktea mentioned this pull request Jun 2, 2022
@bobstrecansky
Copy link
Collaborator

@yuktea - #686 has been merged. Does that unblock you on this PR?

@yuktea
Copy link
Contributor Author

yuktea commented Jun 16, 2022

@bobstrecansky yes it does!

@yuktea yuktea force-pushed the vanilla-php-trace-context-service branch from 7c02ada to d9406d7 Compare June 18, 2022 11:23
@yuktea yuktea marked this pull request as ready for review June 18, 2022 11:23
@codecov
Copy link

codecov bot commented Jun 18, 2022

Codecov Report

Merging #695 (32a8fa6) into main (a22f9f1) will decrease coverage by 0.41%.
The diff coverage is 75.94%.

❗ Current head 32a8fa6 differs from pull request most recent head 34613ca. Consider uploading reports for the commit 34613ca to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #695      +/-   ##
============================================
- Coverage     82.78%   82.37%   -0.42%     
- Complexity     1241     1249       +8     
============================================
  Files           139      140       +1     
  Lines          3033     3052      +19     
============================================
+ Hits           2511     2514       +3     
- Misses          522      538      +16     
Flag Coverage Δ
7.4 82.37% <76.12%> (-0.41%) ⬇️
8.0 82.43% <76.12%> (-0.41%) ⬇️
8.1 82.43% <76.12%> (-0.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/SDK/Trace/ImmutableSpan.php 100.00% <ø> (ø)
src/SDK/Trace/SpanBuilder.php 0.00% <0.00%> (ø)
src/SDK/Trace/Tracer.php 100.00% <ø> (ø)
src/SDK/Trace/TracerProvider.php 72.54% <12.50%> (-27.46%) ⬇️
src/SDK/Trace/SpanLimits.php 75.00% <77.77%> (ø)
src/SDK/Common/Attribute/AttributesBuilder.php 83.33% <83.33%> (ø)
src/SDK/Trace/Span.php 94.23% <92.00%> (+0.53%) ⬆️
src/SDK/Common/Attribute/Attributes.php 100.00% <100.00%> (ø)
src/SDK/Common/Attribute/AttributesFactory.php 100.00% <100.00%> (ø)
src/SDK/Resource/Detectors/Composer.php 85.71% <100.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a22f9f1...34613ca. Read the comment docs.

@yuktea
Copy link
Contributor Author

yuktea commented Jun 18, 2022

Ready for review

/cc @bobstrecansky @tidal

Makefile Show resolved Hide resolved
@bobstrecansky bobstrecansky merged commit 5c3109a into open-telemetry:main Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants