Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent creation of invalid trace id / span id in RandomIdGenerator #699

Merged

Conversation

Nevay
Copy link
Contributor

@Nevay Nevay commented Jun 3, 2022

No description provided.

@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #699 (404a3c0) into main (e728c53) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 404a3c0 differs from pull request most recent head fa90a49. Consider uploading reports for the commit fa90a49 to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #699      +/-   ##
============================================
+ Coverage     83.82%   83.84%   +0.02%     
  Complexity     1233     1233              
============================================
  Files           138      138              
  Lines          2980     2984       +4     
============================================
+ Hits           2498     2502       +4     
  Misses          482      482              
Flag Coverage Δ
7.4 83.84% <100.00%> (+0.02%) ⬆️
8.0 83.89% <100.00%> (+0.02%) ⬆️
8.1 83.89% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/SDK/Trace/RandomIdGenerator.php 85.71% <100.00%> (+5.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e728c53...fa90a49. Read the comment docs.

@brettmc brettmc merged commit 3ca87a8 into open-telemetry:main Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants