fixing BC alias for InstrumentationLibrary #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #706 +/- ##
=========================================
Coverage 83.06% 83.06%
Complexity 1234 1234
=========================================
Files 138 138
Lines 3012 3012
=========================================
Hits 2502 2502
Misses 510 510
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
bobstrecansky
approved these changes
Jun 8, 2022
There was a problem hiding this comment.
Approving but Brett also mentioned double checking with @tidal
tidal
reviewed
Jun 9, 2022
src/SDK/Common/Dev/Compatibility/BC/InstrumentationLibraryInterface.php
Outdated
Show resolved
Hide resolved
…rface.php feedback Co-authored-by: Timo Michna <timomichna@yahoo.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly aliasing the renamed InstrumentationLibraryInterface to the new InstrumentationScopeInterface
Fixes #702