Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overriding attribute increases total count #710

Merged
merged 2 commits into from
Jun 16, 2022

Conversation

Nevay
Copy link
Contributor

@Nevay Nevay commented Jun 15, 2022

No description provided.

@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #710 (7ed90a6) into main (e728c53) will decrease coverage by 1.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #710      +/-   ##
============================================
- Coverage     83.82%   82.77%   -1.05%     
- Complexity     1233     1243      +10     
============================================
  Files           138      139       +1     
  Lines          2980     3037      +57     
============================================
+ Hits           2498     2514      +16     
- Misses          482      523      +41     
Flag Coverage Δ
7.4 82.77% <100.00%> (-1.06%) ⬇️
8.0 82.82% <100.00%> (-1.05%) ⬇️
8.1 82.82% <100.00%> (-1.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/SDK/Common/Attribute/Attributes.php 100.00% <100.00%> (ø)
src/API/Trace/SpanContext.php 82.92% <0.00%> (-4.26%) ⬇️
src/API/Trace/TraceState.php 100.00% <0.00%> (ø)
...c/API/Trace/Propagation/TraceContextPropagator.php 100.00% <0.00%> (ø)
src/SDK/Common/Util/TracingUtil.php
src/SDK/Common/Exception/StackTraceFormatter.php 0.00% <0.00%> (ø)
...ation/SanitizeCombinedHeadersPropagationGetter.php 0.00% <0.00%> (ø)
src/SDK/Trace/RandomIdGenerator.php 85.71% <0.00%> (+5.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e728c53...7ed90a6. Read the comment docs.

@brettmc brettmc merged commit 3c6c53b into open-telemetry:main Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants