Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Samplers to return null instead of provided attributes #713

Conversation

Nevay
Copy link
Contributor

@Nevay Nevay commented Jun 16, 2022

Returned attributes are additional attributes; AlwaysOffSampler already returns null.
"A set of span Attributes that will also be added to the Span."

"A set of span Attributes that will also be added to the Span"
@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #713 (b1dddc6) into main (e728c53) will decrease coverage by 1.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #713      +/-   ##
============================================
- Coverage     83.82%   82.77%   -1.05%     
- Complexity     1233     1243      +10     
============================================
  Files           138      139       +1     
  Lines          2980     3037      +57     
============================================
+ Hits           2498     2514      +16     
- Misses          482      523      +41     
Flag Coverage Δ
7.4 82.77% <100.00%> (-1.06%) ⬇️
8.0 82.82% <100.00%> (-1.05%) ⬇️
8.1 82.82% <100.00%> (-1.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/SDK/Trace/Sampler/AlwaysOnSampler.php 100.00% <ø> (ø)
src/SDK/Trace/Sampler/TraceIdRatioBasedSampler.php 100.00% <100.00%> (ø)
src/API/Trace/SpanContext.php 82.92% <0.00%> (-4.26%) ⬇️
src/API/Trace/TraceState.php 100.00% <0.00%> (ø)
src/SDK/Common/Attribute/Attributes.php 100.00% <0.00%> (ø)
...c/API/Trace/Propagation/TraceContextPropagator.php 100.00% <0.00%> (ø)
src/SDK/Common/Util/TracingUtil.php
...ation/SanitizeCombinedHeadersPropagationGetter.php 0.00% <0.00%> (ø)
src/SDK/Common/Exception/StackTraceFormatter.php 0.00% <0.00%> (ø)
src/SDK/Trace/RandomIdGenerator.php 85.71% <0.00%> (+5.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e728c53...b1dddc6. Read the comment docs.

@bobstrecansky bobstrecansky merged commit 345f8bf into open-telemetry:main Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants