Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make AttributesInterface immutable #724

Merged
merged 8 commits into from
Jun 23, 2022

Conversation

Nevay
Copy link
Contributor

@Nevay Nevay commented Jun 22, 2022

Makes AttributesInterface immutable by introducing AttributesBuilderInterface as mutable builder.

Resolves #709, see also #542.

@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #724 (572712e) into main (122aff0) will decrease coverage by 0.04%.
The diff coverage is 83.09%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #724      +/-   ##
============================================
- Coverage     82.41%   82.37%   -0.05%     
- Complexity     1247     1249       +2     
============================================
  Files           139      140       +1     
  Lines          3048     3052       +4     
============================================
+ Hits           2512     2514       +2     
- Misses          536      538       +2     
Flag Coverage Δ
7.4 82.37% <83.45%> (-0.03%) ⬇️
8.0 82.43% <83.45%> (-0.03%) ⬇️
8.1 82.43% <83.45%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/SDK/Trace/ImmutableSpan.php 100.00% <ø> (ø)
src/SDK/Trace/SpanBuilder.php 0.00% <0.00%> (ø)
src/SDK/Trace/Tracer.php 100.00% <ø> (ø)
src/SDK/Trace/SpanLimits.php 75.00% <77.77%> (ø)
src/SDK/Common/Attribute/AttributesBuilder.php 83.33% <83.33%> (ø)
src/SDK/Trace/Span.php 94.23% <92.00%> (+0.53%) ⬆️
src/SDK/Common/Attribute/Attributes.php 100.00% <100.00%> (ø)
src/SDK/Common/Attribute/AttributesFactory.php 100.00% <100.00%> (ø)
src/SDK/Resource/Detectors/Composer.php 85.71% <100.00%> (ø)
src/SDK/Resource/Detectors/Environment.php 100.00% <100.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 122aff0...572712e. Read the comment docs.

@Nevay Nevay marked this pull request as ready for review June 22, 2022 17:56
@brettmc brettmc merged commit 41f74d2 into open-telemetry:main Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributesInterface should be immutable
2 participants