Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic InstrumentationInterface and InstrumentationTrait #726

Merged
merged 8 commits into from
Jun 24, 2022

Conversation

tidal
Copy link
Member

@tidal tidal commented Jun 23, 2022

Adds an InstrumentationInterface and InstrumentationTrait which are meant as a base for (contrib) instrumentations.
(Registering/Activating the Instrumentation with the API has yet to be implemted)

@tidal tidal force-pushed the instrumentation branch 2 times, most recently from 957f11d to 8d0dc43 Compare June 23, 2022 18:17
@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #726 (e06cc49) into main (41f74d2) will increase coverage by 0.27%.
The diff coverage is 94.44%.

❗ Current head e06cc49 differs from pull request most recent head bf90874. Consider uploading reports for the commit bf90874 to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #726      +/-   ##
============================================
+ Coverage     82.37%   82.65%   +0.27%     
- Complexity     1249     1271      +22     
============================================
  Files           140      145       +5     
  Lines          3052     3124      +72     
============================================
+ Hits           2514     2582      +68     
- Misses          538      542       +4     
Flag Coverage Δ
7.4 82.65% <94.44%> (+0.28%) ⬆️
8.0 82.71% <94.44%> (+0.27%) ⬆️
8.1 82.71% <94.44%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/API/Metrics/NoopMeterProvider.php 0.00% <0.00%> (ø)
src/API/Trace/NoopTracerProvider.php 0.00% <0.00%> (ø)
...PI/Common/Instrumentation/InstrumentationTrait.php 100.00% <100.00%> (ø)
src/API/Metrics/NoopMeter.php 100.00% <100.00%> (ø)
src/Context/Propagation/NullPropagator.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41f74d2...bf90874. Read the comment docs.

@tidal tidal merged commit 0e4ad52 into open-telemetry:main Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants