Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor TraceState's __toString method #727 Span Attributes Documentation#704 #729

Merged
merged 8 commits into from
Jun 29, 2022

Conversation

amber0612
Copy link
Contributor

@amber0612 amber0612 commented Jun 25, 2022

@codecov
Copy link

codecov bot commented Jun 25, 2022

Codecov Report

Merging #729 (90865ed) into main (5c3109a) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #729      +/-   ##
============================================
- Coverage     82.65%   82.63%   -0.02%     
- Complexity     1271     1272       +1     
============================================
  Files           145      145              
  Lines          3124     3121       -3     
============================================
- Hits           2582     2579       -3     
  Misses          542      542              
Flag Coverage Δ
7.4 82.63% <100.00%> (-0.02%) ⬇️
8.0 82.69% <100.00%> (-0.02%) ⬇️
8.1 82.69% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/API/Trace/TraceState.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c3109a...90865ed. Read the comment docs.

@amber0612 amber0612 changed the title Defining Span Attributes at Span creation Documentation #704 Refactor TraceState's __toString method #727 Span Attributes Documentation#704 Jun 27, 2022
@amber0612 amber0612 marked this pull request as draft June 27, 2022 13:32
@amber0612 amber0612 marked this pull request as ready for review June 28, 2022 06:26
@bobstrecansky bobstrecansky merged commit 06d74a7 into open-telemetry:main Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor TraceState's __toString method Defining attributes at span creation
2 participants