-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rector and PHP 7.4 rules #739
Conversation
Codecov Report
@@ Coverage Diff @@
## main #739 +/- ##
============================================
- Coverage 82.55% 82.53% -0.02%
Complexity 1272 1272
============================================
Files 146 146
Lines 3130 3127 -3
============================================
- Hits 2584 2581 -3
Misses 546 546
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@bobstrecansky @brettmc |
As discussed (long ago) we want to use Rector to automatically refactor our code base to be more consistent and automate the upgrade to higher PHP Versions once support for a specific version is dropped.
This PR adds rector as a dependecy and applies rules to upgrade the code base completely to PHP 7.4.
(I will add more rector rules gardually in future PRs, as otherwise this will be a nightmare to review)