Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group otlp spans by resource #740

Merged

Conversation

Nevay
Copy link
Contributor

@Nevay Nevay commented Jun 30, 2022

Resolves #712.

I left SpanConverterInterface untouched for now - I'm in favor of removing the interface as span converters of different exporters are not interoperable.

@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #740 (26e7f6b) into main (739f212) will decrease coverage by 0.04%.
The diff coverage is 98.96%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #740      +/-   ##
============================================
- Coverage     82.55%   82.51%   -0.05%     
+ Complexity     1272     1263       -9     
============================================
  Files           146      145       -1     
  Lines          3130     3128       -2     
============================================
- Hits           2584     2581       -3     
- Misses          546      547       +1     
Flag Coverage Δ
7.4 82.51% <98.94%> (-0.05%) ⬇️
8.0 82.57% <98.96%> (-0.05%) ⬇️
8.1 82.57% <98.96%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Contrib/Otlp/SpanConverter.php 99.14% <98.96%> (-0.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 739f212...26e7f6b. Read the comment docs.

@Nevay Nevay force-pushed the fix/group-otlp-spans-by-resource branch from 718c999 to 02214ff Compare June 30, 2022 17:51
Caused by `RepeatedField` being not generic.
@Nevay Nevay marked this pull request as ready for review June 30, 2022 18:11
@bobstrecansky bobstrecansky merged commit 4c10268 into open-telemetry:main Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Otlp\SpanConverter has to group by resource
2 participants