Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply rector Code Quality rules #743

Merged
merged 2 commits into from
Jul 2, 2022
Merged

Conversation

tidal
Copy link
Member

@tidal tidal commented Jul 2, 2022

No description provided.

@tidal tidal changed the title Apply rector Code Quality rule Apply rector Code Quality rules Jul 2, 2022
@codecov
Copy link

codecov bot commented Jul 2, 2022

Codecov Report

Merging #743 (015a55f) into main (4c10268) will decrease coverage by 0.04%.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #743      +/-   ##
============================================
- Coverage     82.49%   82.44%   -0.05%     
- Complexity     1263     1265       +2     
============================================
  Files           145      145              
  Lines          3125     3122       -3     
============================================
- Hits           2578     2574       -4     
- Misses          547      548       +1     
Flag Coverage Δ
7.4 82.45% <83.33%> (-0.05%) ⬇️
8.0 82.50% <83.33%> (-0.05%) ⬇️
8.1 82.50% <83.33%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Context/FiberBoundContextStorage.php 0.00% <0.00%> (ø)
...rc/Contrib/Context/Swoole/SwooleContextStorage.php 0.00% <0.00%> (ø)
src/SDK/Common/Exception/StackTraceFormatter.php 0.00% <0.00%> (ø)
src/API/Baggage/Baggage.php 83.87% <100.00%> (ø)
src/API/Baggage/Propagation/BaggagePropagator.php 100.00% <100.00%> (ø)
...c/API/Trace/Propagation/TraceContextPropagator.php 100.00% <100.00%> (ø)
src/API/Trace/TraceState.php 100.00% <100.00%> (ø)
...rc/Context/Propagation/ArrayAccessGetterSetter.php 91.11% <100.00%> (ø)
src/Contrib/Jaeger/SpanConverter.php 95.23% <100.00%> (-0.06%) ⬇️
src/Contrib/Jaeger/TagFactory/TagFactory.php 100.00% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c10268...015a55f. Read the comment docs.

@bobstrecansky bobstrecansky merged commit 47ee3e9 into open-telemetry:main Jul 2, 2022
@tidal tidal deleted the rector branch July 2, 2022 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants