Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTP Dependency Resolvers #744

Merged
merged 20 commits into from
Jul 2, 2022
Merged

Conversation

tidal
Copy link
Member

@tidal tidal commented Jul 2, 2022

  • Adds Resolvers for HTTP dependencies for future use in Exporter Client (etc.) rework.

related:

(Decorators from #731 will be added in a future PR once reworked to work as intended)

@codecov
Copy link

codecov bot commented Jul 2, 2022

Codecov Report

Merging #744 (3e22395) into main (739f212) will increase coverage by 0.33%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #744      +/-   ##
============================================
+ Coverage     82.55%   82.89%   +0.33%     
- Complexity     1272     1294      +22     
============================================
  Files           146      150       +4     
  Lines          3130     3197      +67     
============================================
+ Hits           2584     2650      +66     
- Misses          546      547       +1     
Flag Coverage Δ
7.4 82.89% <100.00%> (+0.33%) ⬆️
8.0 82.95% <100.00%> (+0.33%) ⬆️
8.1 82.95% <100.00%> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ommon/Adapter/HttpDiscovery/DependencyResolver.php 100.00% <100.00%> (ø)
...n/Adapter/HttpDiscovery/HttpPlugClientResolver.php 100.00% <100.00%> (ø)
...n/Adapter/HttpDiscovery/MessageFactoryResolver.php 100.00% <100.00%> (ø)
...Common/Adapter/HttpDiscovery/PsrClientResolver.php 100.00% <100.00%> (ø)
src/SDK/Common/Http/Psr/Message/MessageFactory.php 100.00% <100.00%> (ø)
src/Contrib/Otlp/SpanConverter.php 99.14% <0.00%> (-0.86%) ⬇️
src/Contrib/Jaeger/SpanConverter.php 95.29% <0.00%> (-0.11%) ⬇️
src/Contrib/Jaeger/JaegerTransport.php 86.66% <0.00%> (ø)
src/Contrib/Jaeger/TagFactory/TagFactory.php 100.00% <0.00%> (ø)
src/SDK/Common/Instrumentation/KeyGenerator.php

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 739f212...3e22395. Read the comment docs.

@tidal tidal marked this pull request as ready for review July 2, 2022 13:56
@bobstrecansky bobstrecansky merged commit 5f318cd into open-telemetry:main Jul 2, 2022
@tidal tidal deleted the http-dep branch July 2, 2022 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants