Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Context #746

Merged
merged 1 commit into from
Jul 2, 2022
Merged

Conversation

tidal
Copy link
Member

@tidal tidal commented Jul 2, 2022

Brings methods and properties into expected order + some minor changes

@codecov
Copy link

codecov bot commented Jul 2, 2022

Codecov Report

Merging #746 (07b355d) into main (4c10268) will decrease coverage by 0.02%.
The diff coverage is 73.68%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #746      +/-   ##
============================================
- Coverage     82.49%   82.46%   -0.03%     
- Complexity     1263     1264       +1     
============================================
  Files           145      145              
  Lines          3125     3120       -5     
============================================
- Hits           2578     2573       -5     
  Misses          547      547              
Flag Coverage Δ
7.4 82.47% <73.68%> (-0.03%) ⬇️
8.0 82.53% <73.68%> (-0.03%) ⬇️
8.1 82.53% <73.68%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Context/Context.php 78.57% <73.68%> (+1.90%) ⬆️
src/Contrib/Zipkin/SpanConverter.php 96.29% <0.00%> (-0.07%) ⬇️
src/Contrib/Jaeger/SpanConverter.php 95.23% <0.00%> (-0.06%) ⬇️
src/API/Trace/TraceState.php 100.00% <0.00%> (ø)
src/SDK/Common/Exception/StackTraceFormatter.php 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c10268...07b355d. Read the comment docs.

@bobstrecansky bobstrecansky merged commit b973c52 into open-telemetry:main Jul 2, 2022
@tidal tidal deleted the context-refactoring branch July 2, 2022 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants