Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid @covers annotations in SpanTest create warning in PHPunit runs #752

Merged
merged 11 commits into from
Jul 13, 2022

Conversation

amber0612
Copy link
Contributor

@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #752 (947b2de) into main (aaa93ee) will decrease coverage by 3.25%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #752      +/-   ##
============================================
- Coverage     82.86%   79.60%   -3.26%     
  Complexity     1295     1295              
============================================
  Files           150      150              
  Lines          3192     3192              
============================================
- Hits           2645     2541     -104     
- Misses          547      651     +104     
Flag Coverage Δ
7.4 79.58% <ø> (-3.29%) ⬇️
8.0 79.66% <ø> (-3.27%) ⬇️
8.1 79.66% <ø> (-3.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/SDK/Trace/Span.php 12.50% <0.00%> (-81.74%) ⬇️
src/SDK/Trace/SpanLimits.php 0.00% <0.00%> (-75.00%) ⬇️
src/API/Trace/AbstractSpan.php 0.00% <0.00%> (-38.89%) ⬇️
src/SDK/Trace/TracerProvider.php 65.00% <0.00%> (ø)
src/SDK/Trace/TracerProviderFactory.php 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaa93ee...947b2de. Read the comment docs.

@amber0612 amber0612 marked this pull request as draft July 6, 2022 11:30
@bobstrecansky
Copy link
Collaborator

Reran these tests after the fix; looks better now.

@amber0612 amber0612 marked this pull request as ready for review July 7, 2022 05:51
@bobstrecansky
Copy link
Collaborator

I think the only thing left on this PR is @brettmc 's comments.

@brettmc brettmc merged commit 82b0135 into open-telemetry:main Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants