Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated ResourceConstants #761

Merged

Conversation

CalinBolea
Copy link
Contributor

Closes #749

@welcome
Copy link

welcome bot commented Jul 11, 2022

Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 11, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: CalinBolea / name: Calin Bolea (3a95f31)

@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #761 (3a95f31) into main (6a14cf9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #761   +/-   ##
=========================================
  Coverage     82.86%   82.86%           
  Complexity     1295     1295           
=========================================
  Files           150      150           
  Lines          3192     3192           
=========================================
  Hits           2645     2645           
  Misses          547      547           
Flag Coverage Δ
7.4 82.87% <ø> (ø)
8.0 82.92% <ø> (ø)
8.1 82.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a14cf9...3a95f31. Read the comment docs.

@bobstrecansky
Copy link
Collaborator

@CalinBolea - once you've signed the CLA, I believe we can merge this.

@CalinBolea
Copy link
Contributor Author

CalinBolea commented Jul 11, 2022

@bobstrecansky done :)

@bobstrecansky bobstrecansky merged commit 24ada8c into open-telemetry:main Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove ResourceConstants
2 participants