Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove null default value from parameters that are never null #779

Conversation

Nevay
Copy link
Contributor

@Nevay Nevay commented Jul 18, 2022

Prevents having to handle null values for parameters that will never be null. Might simplifiy user implementations and removes ambiguity if the meaning of null is not obvious.

@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #779 (0b70cf0) into main (5a64c0d) will increase coverage by 0.11%.
The diff coverage is 33.33%.

❗ Current head 0b70cf0 differs from pull request most recent head 9e9712a. Consider uploading reports for the commit 9e9712a to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #779      +/-   ##
============================================
+ Coverage     79.53%   79.64%   +0.11%     
+ Complexity     1409     1394      -15     
============================================
  Files           160      160              
  Lines          3479     3469      -10     
============================================
- Hits           2767     2763       -4     
+ Misses          712      706       -6     
Flag Coverage Δ
7.4 ?
8.0 ?
8.1 79.64% <33.33%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/SDK/Trace/Sampler/AlwaysOffSampler.php 100.00% <ø> (ø)
src/SDK/Trace/Sampler/AlwaysOnSampler.php 100.00% <ø> (ø)
src/SDK/Trace/Sampler/ParentBased.php 100.00% <ø> (ø)
src/SDK/Trace/Sampler/TraceIdRatioBasedSampler.php 100.00% <ø> (ø)
src/SDK/Trace/SpanBuilder.php 0.00% <0.00%> (ø)
src/SDK/Trace/SpanProcessor/BatchSpanProcessor.php 100.00% <ø> (ø)
src/SDK/Trace/SpanProcessor/NoopSpanProcessor.php 100.00% <ø> (ø)
...rc/SDK/Trace/SpanProcessor/SimpleSpanProcessor.php 100.00% <ø> (ø)
src/SDK/Trace/SpanProcessor/MultiSpanProcessor.php 100.00% <100.00%> (ø)
src/SDK/Common/Dsn/Factory.php 100.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a64c0d...9e9712a. Read the comment docs.

@brettmc brettmc merged commit 2f6658f into open-telemetry:main Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants