Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic coding guidelines section in DEVELOPMENT #781

Merged
merged 2 commits into from
Jul 19, 2022

Conversation

tidal
Copy link
Member

@tidal tidal commented Jul 19, 2022

We maintainers want to add basic coding guidelines as an orientation for pull requests and as a reference for reviews.

  • Adds basic coding guidelines section with a link to Clean Code PHP
  • Moves the examples section back to the main README, as it enjoyed its stay in DEVELOPMENT.md but wants to have a more prominent place again.

@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #781 (5da612d) into main (ea5b7c1) will increase coverage by 0.97%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #781      +/-   ##
============================================
+ Coverage     78.51%   79.49%   +0.97%     
- Complexity     1337     1407      +70     
============================================
  Files           154      160       +6     
  Lines          3291     3472     +181     
============================================
+ Hits           2584     2760     +176     
- Misses          707      712       +5     
Flag Coverage Δ
7.4 79.49% <ø> (+0.97%) ⬆️
8.0 79.56% <ø> (+0.96%) ⬆️
8.1 79.56% <ø> (+0.96%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/SDK/Trace/ExporterFactory.php 100.00% <0.00%> (ø)
src/SDK/Common/Dsn/Factory.php 100.00% <0.00%> (ø)
src/SDK/Common/Dsn/Dsn.php 90.90% <0.00%> (ø)
src/API/Common/Event/EmitsEventsTrait.php 100.00% <0.00%> (ø)
src/SDK/Common/Otlp/HttpEndpointResolver.php 100.00% <0.00%> (ø)
src/API/Common/Event/Dispatcher.php 100.00% <0.00%> (ø)
src/SDK/Common/Dsn/Parser.php 100.00% <0.00%> (ø)
src/Contrib/OtlpHttp/Exporter.php 94.00% <0.00%> (+1.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea5b7c1...5da612d. Read the comment docs.

@bobstrecansky bobstrecansky merged commit 32c4384 into open-telemetry:main Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants