Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for concurrent exports #790

Merged
merged 2 commits into from
Aug 10, 2022

Conversation

Nevay
Copy link
Contributor

@Nevay Nevay commented Aug 5, 2022

Related to #788.

The return of Export() is implementation specific. In what is idiomatic for the language the Exporter must send an ExportResult to the Processor. ExportResult has values of either Success or Failure

@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #790 (903d9bc) into main (e946dc7) will decrease coverage by 0.09%.
The diff coverage is 63.63%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #790      +/-   ##
============================================
- Coverage     79.52%   79.43%   -0.10%     
- Complexity     1405     1407       +2     
============================================
  Files           160      161       +1     
  Lines          3468     3472       +4     
============================================
  Hits           2758     2758              
- Misses          710      714       +4     
Flag Coverage Δ
7.4 79.43% <63.63%> (-0.10%) ⬇️
8.0 79.50% <63.63%> (-0.10%) ⬇️
8.1 79.50% <63.63%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/SDK/Common/Future/CompletedFuture.php 0.00% <0.00%> (ø)
.../SDK/Trace/Behavior/SpanExporterDecoratorTrait.php 100.00% <100.00%> (ø)
src/SDK/Trace/Behavior/SpanExporterTrait.php 100.00% <100.00%> (ø)
src/SDK/Trace/SpanProcessor/BatchSpanProcessor.php 100.00% <100.00%> (ø)
...rc/SDK/Trace/SpanProcessor/SimpleSpanProcessor.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e946dc7...903d9bc. Read the comment docs.

@Nevay Nevay marked this pull request as ready for review August 7, 2022 09:15
@brettmc
Copy link
Collaborator

brettmc commented Aug 7, 2022

Looks good to me. Futures look quite similar to Promises, I was going to ask why not use promises (esp given recent cancellation work), but I think I talked myself out of it.
I'll wait a day or two to see if anybody else wants to also review.

@bobstrecansky bobstrecansky merged commit d0a600f into open-telemetry:main Aug 10, 2022
@Nevay Nevay deleted the feature/concurrent-exports branch April 19, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants