Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding getTracerProvider to Instrumentation #797

Merged
merged 2 commits into from
Aug 13, 2022
Merged

adding getTracerProvider to Instrumentation #797

merged 2 commits into from
Aug 13, 2022

Conversation

brettmc
Copy link
Collaborator

@brettmc brettmc commented Aug 11, 2022

AWS instrumentation needs access to the tracer provider, so keep a reference in InstrumentationTrait (which should also resolve premature shutdown, if the caller wasn't keeping a reference to the tracer provider).

@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #797 (a8c1742) into main (4dd375f) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #797      +/-   ##
============================================
- Coverage     80.40%   80.37%   -0.03%     
- Complexity     1765     1766       +1     
============================================
  Files           222      222              
  Lines          4516     4520       +4     
============================================
+ Hits           3631     3633       +2     
- Misses          885      887       +2     
Flag Coverage Δ
7.4 80.37% <50.00%> (-0.03%) ⬇️
8.0 80.40% <50.00%> (-0.03%) ⬇️
8.1 80.40% <50.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...PI/Common/Instrumentation/InstrumentationTrait.php 94.73% <50.00%> (-5.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dd375f...a8c1742. Read the comment docs.

@brettmc brettmc merged commit cb002a8 into open-telemetry:main Aug 13, 2022
@brettmc brettmc deleted the instrumentation-tracer-provider branch October 25, 2022 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants