Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing psalm security analysis workflow #799

Merged
merged 1 commit into from
Aug 13, 2022
Merged

removing psalm security analysis workflow #799

merged 1 commit into from
Aug 13, 2022

Conversation

brettmc
Copy link
Collaborator

@brettmc brettmc commented Aug 13, 2022

we already run psalm in the php workflow. this one doesn't add much, and is more flaky. we have decided that the serif uploading is not very important since we have good makefile-based ability for devs to run this all locally before pushing

we already run psalm in the php workflow. this one doesn't add much, and is more flaky. we have decided that the serif uploading is not very important since we have good makefile-based ability for devs to run this all locally before pushing
@codecov
Copy link

codecov bot commented Aug 13, 2022

Codecov Report

Merging #799 (615d76f) into main (3ac64f6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #799   +/-   ##
=========================================
  Coverage     80.40%   80.40%           
  Complexity     1765     1765           
=========================================
  Files           222      222           
  Lines          4516     4516           
=========================================
  Hits           3631     3631           
  Misses          885      885           
Flag Coverage Δ
7.4 80.40% <ø> (ø)
8.0 80.43% <ø> (ø)
8.1 80.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ac64f6...615d76f. Read the comment docs.

@bobstrecansky bobstrecansky merged commit 4dd375f into open-telemetry:main Aug 13, 2022
@brettmc brettmc deleted the remove-psalm-security branch October 25, 2022 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants