Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump protobuf to 0.19, handle grpc partial success #806

Merged
merged 10 commits into from
Sep 6, 2022
Merged

bump protobuf to 0.19, handle grpc partial success #806

merged 10 commits into from
Sep 6, 2022

Conversation

brettmc
Copy link
Collaborator

@brettmc brettmc commented Aug 25, 2022

Update protobuf files to 0.19
Handle gRPC partial success on export
Add logging to grpc examples.
Fix a race condition in one of the smoke tests

This addresses the gRPC requirement for #802 but not http.

@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #806 (5e56347) into main (0f30849) will increase coverage by 1.85%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #806      +/-   ##
============================================
+ Coverage     81.03%   82.88%   +1.85%     
- Complexity     1825     1829       +4     
============================================
  Files           225      225              
  Lines          4687     4697      +10     
============================================
+ Hits           3798     3893      +95     
+ Misses          889      804      -85     
Flag Coverage Δ
7.4 82.89% <100.00%> (+1.86%) ⬆️
8.0 82.91% <100.00%> (+1.85%) ⬆️
8.1 82.91% <100.00%> (+1.85%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Contrib/OtlpGrpc/Exporter.php 91.42% <100.00%> (+1.26%) ⬆️
src/SDK/Trace/Behavior/HttpSpanExporterTrait.php 93.61% <100.00%> (+0.13%) ⬆️
src/SDK/Trace/Span.php 94.23% <0.00%> (+81.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f30849...5e56347. Read the comment docs.

trying to mock this class with phpunit or mockery segfaults when the protobuf extension is installed
@Nevay
Copy link
Contributor

Nevay commented Aug 25, 2022

Unblocks #738.

Copy link
Contributor

@Nevay Nevay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OTLP/HTTP has to handle partial success responses too.

src/Contrib/OtlpGrpc/Exporter.php Show resolved Hide resolved
@brettmc
Copy link
Collaborator Author

brettmc commented Aug 26, 2022

OTLP/HTTP has to handle partial success responses too

Agreed. This has not yet been implemented in the otel collector (open-telemetry/opentelemetry-collector#5816 is the feature request), and currently otlp/http always returns an empty response.
I'll change this PR so that it doesn't close #802, I think we should wait until there's a protobuf response from the collector to work with...

@brettmc
Copy link
Collaborator Author

brettmc commented Aug 26, 2022

more segfault. I'll be offline for a couple of days, will look in to this later. Both mockery and phpunit mock objects segfault in much the same way.

mocking protobuf with c extension is not supported, so document this and work around
@brettmc brettmc merged commit ea83a0c into open-telemetry:main Sep 6, 2022
@brettmc brettmc deleted the proto-0.19 branch October 25, 2022 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants