-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump protobuf to 0.19, handle grpc partial success #806
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #806 +/- ##
============================================
+ Coverage 81.03% 82.88% +1.85%
- Complexity 1825 1829 +4
============================================
Files 225 225
Lines 4687 4697 +10
============================================
+ Hits 3798 3893 +95
+ Misses 889 804 -85
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
trying to mock this class with phpunit or mockery segfaults when the protobuf extension is installed
Unblocks #738. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OTLP/HTTP has to handle partial success responses too.
Agreed. This has not yet been implemented in the otel collector (open-telemetry/opentelemetry-collector#5816 is the feature request), and currently otlp/http always returns an empty response. |
more segfault. I'll be offline for a couple of days, will look in to this later. Both mockery and phpunit mock objects segfault in much the same way. |
mocking protobuf with c extension is not supported, so document this and work around
Update protobuf files to 0.19
Handle gRPC partial success on export
Add logging to grpc examples.
Fix a race condition in one of the smoke tests
This addresses the gRPC requirement for #802 but not http.