Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing php8.2 string usage #810

Merged
merged 2 commits into from
Sep 7, 2022
Merged

fixing php8.2 string usage #810

merged 2 commits into from
Sep 7, 2022

Conversation

brettmc
Copy link
Collaborator

@brettmc brettmc commented Sep 2, 2022

This resolves some deprecation warnings in php 8.2:
Deprecated: Using ${var} in strings is deprecated, use {$var} instead

This resolves some deprecation warnings in php 8.2:
Deprecated: Using ${var} in strings is deprecated, use {$var} instead
@codecov
Copy link

codecov bot commented Sep 2, 2022

Codecov Report

Merging #810 (a99ec16) into main (2cb5d6b) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #810   +/-   ##
=========================================
  Coverage     82.88%   82.88%           
  Complexity     1829     1829           
=========================================
  Files           225      225           
  Lines          4697     4697           
=========================================
  Hits           3893     3893           
  Misses          804      804           
Flag Coverage Δ
7.4 82.89% <ø> (ø)
8.0 82.91% <ø> (ø)
8.1 82.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cb5d6b...a99ec16. Read the comment docs.

@brettmc brettmc requested a review from a team as a code owner September 7, 2022 12:44
@brettmc brettmc merged commit ac3a35d into open-telemetry:main Sep 7, 2022
@brettmc brettmc deleted the php82-strings branch September 7, 2022 13:03
@brettmc brettmc mentioned this pull request Sep 20, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants