Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore phpstan false positive on metrics multiobserver #813

Merged
merged 1 commit into from
Sep 7, 2022
Merged

ignore phpstan false positive on metrics multiobserver #813

merged 1 commit into from
Sep 7, 2022

Conversation

brettmc
Copy link
Collaborator

@brettmc brettmc commented Sep 6, 2022

metrics observer callbacks can be removed mid-flight, so ignore the false positive

@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #813 (dc63b22) into main (77838b3) will increase coverage by 1.85%.
The diff coverage is 100.00%.

❗ Current head dc63b22 differs from pull request most recent head 783768c. Consider uploading reports for the commit 783768c to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #813      +/-   ##
============================================
+ Coverage     81.03%   82.88%   +1.85%     
- Complexity     1825     1829       +4     
============================================
  Files           225      225              
  Lines          4687     4697      +10     
============================================
+ Hits           3798     3893      +95     
+ Misses          889      804      -85     
Flag Coverage Δ
7.4 82.89% <100.00%> (+1.86%) ⬆️
8.0 82.91% <100.00%> (+1.85%) ⬆️
8.1 82.91% <100.00%> (+1.85%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Contrib/OtlpGrpc/Exporter.php 91.42% <100.00%> (+1.26%) ⬆️
src/SDK/Metrics/MetricObserver/MultiObserver.php 100.00% <100.00%> (ø)
src/SDK/Trace/Behavior/HttpSpanExporterTrait.php 93.61% <100.00%> (+0.13%) ⬆️
src/SDK/Trace/Span.php 94.23% <0.00%> (+81.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77838b3...783768c. Read the comment docs.

@brettmc brettmc merged commit 2cb5d6b into open-telemetry:main Sep 7, 2022
@brettmc brettmc deleted the bugfix/phpstan-metrics-multi-observer branch October 25, 2022 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants