Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add interfaces for Context and ContextKey #820

Merged
merged 6 commits into from
Sep 18, 2022
Merged

Add interfaces for Context and ContextKey #820

merged 6 commits into from
Sep 18, 2022

Conversation

Nevay
Copy link
Contributor

@Nevay Nevay commented Sep 9, 2022

Resolves #795.

Nevay
Nevay commented Sep 9, 2022
View reviewed changes
src/API/Trace/SpanBuilderInterface.php Outdated Show resolved Hide resolved
src/Context/ImplicitContextKeyedInterface.php Outdated Show resolved Hide resolved
src/Context/Propagation/NullPropagator.php Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 9, 2022 •
edited

Codecov Report

Merging #820 (c767d9f) into main (b551294) will decrease coverage by 0.02%.
The diff coverage is 77.14%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #820      +/-   ##
============================================
- Coverage     82.57%   82.54%   -0.03%     
+ Complexity     1884     1876       -8     
============================================
  Files           231      230       -1     
  Lines          4901     4887      -14     
============================================
- Hits           4047     4034      -13     
+ Misses          854      853       -1
Flag Coverage Δ
7.4 82.55% <77.14%> (-0.03%) ⬇️
8.0 82.57% <77.14%> (-0.03%) ⬇️
8.1 82.57% <77.14%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/API/Trace/Span.php 0.00% <0.00%> (ø)
src/Context/ContextKey.php 100.00% <ø> (ø)
src/Context/FiberBoundContextStorage.php 0.00% <0.00%> (ø)
src/Context/FiberBoundContextStorageScope.php 0.00% <0.00%> (ø)
src/Contrib/Context/Swoole/SwooleContextScope.php 0.00% <0.00%> (ø)
...rc/Contrib/Context/Swoole/SwooleContextStorage.php 0.00% <0.00%> (ø)
src/SDK/Metrics/Exemplar/NoopReservoir.php 100.00% <ø> (ø)
src/SDK/Trace/Sampler/AlwaysOffSampler.php 100.00% <ø> (ø)
src/SDK/Trace/Sampler/AlwaysOnSampler.php 100.00% <ø> (ø)
src/SDK/Trace/Sampler/ParentBased.php 100.00% <ø> (ø)
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b551294...c767d9f. Read the comment docs.

@Nevay Nevay marked this pull request as ready for review September 9, 2022 20:50
@Nevay Nevay requested a review from a team as a code owner September 9, 2022 20:50
@Nevay Nevay force-pushed the feature/context-interfaces branch 2 times, most recently from bb92785 to 196c60a Compare September 14, 2022 17:59
brettmc
brettmc approved these changes Sep 14, 2022
View reviewed changes
Copy link
Collaborator

@brettmc brettmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, some conflicts to be resolved before we can merge

@brettmc brettmc merged commit deeb07a into open-telemetry:main Sep 18, 2022
@Nevay Nevay deleted the feature/context-interfaces branch April 19, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettmc brettmc brettmc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add interfaces for Context and ContextKey
2 participants
@Nevay @brettmc