Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug scope to warn on incorrect scope usage #823

Merged
merged 2 commits into from
Sep 13, 2022

Conversation

Nevay
Copy link
Contributor

@Nevay Nevay commented Sep 12, 2022

No description provided.

@Nevay Nevay requested a review from a team as a code owner September 12, 2022 19:20
@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #823 (e3a0e3a) into main (776273c) will increase coverage by 0.05%.
The diff coverage is 97.67%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #823      +/-   ##
============================================
+ Coverage     82.77%   82.82%   +0.05%     
- Complexity     1817     1829      +12     
============================================
  Files           222      223       +1     
  Lines          4661     4723      +62     
============================================
+ Hits           3858     3912      +54     
- Misses          803      811       +8     
Flag Coverage Δ
7.4 82.84% <97.67%> (+0.05%) ⬆️
8.0 82.86% <97.67%> (+0.05%) ⬆️
8.1 82.86% <97.67%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Context/DebugScope.php 97.50% <97.50%> (ø)
src/Context/Context.php 80.00% <100.00%> (+1.42%) ⬆️
src/SDK/Common/Util/WeakMap.php 0.00% <0.00%> (ø)
src/Context/ContextStorageNode.php 100.00% <0.00%> (ø)
src/SDK/Metrics/Stream/DeltaStorage.php 100.00% <0.00%> (ø)
src/Context/FiberBoundContextStorage.php 0.00% <0.00%> (ø)
src/SDK/Metrics/Exemplar/BucketStorage.php 100.00% <0.00%> (ø)
src/Context/FiberBoundContextStorageScope.php 0.00% <0.00%> (ø)
src/SDK/Trace/SpanProcessor/BatchSpanProcessor.php 100.00% <0.00%> (ø)
...rc/SDK/Metrics/Stream/AsynchronousMetricStream.php 100.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 776273c...e3a0e3a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants