Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename AbstractSpan to Span for consistent access to static methods #824

Merged

Conversation

Nevay
Copy link
Contributor

@Nevay Nevay commented Sep 13, 2022

Unifies access to static interface methods. Other API interfaces with static methods have a class without the Interface suffix that provides an implementation, e.g.:
Baggage::getCurrent(): BaggageInterface
SpanContext::getInvalid(): SpanContextInterface

I considered creating a Span class that does not implement SpanInterface but disliked the idea of splitting the PHPDoc documentation in different classes.

@Nevay Nevay requested a review from a team as a code owner September 13, 2022 19:24
@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #824 (48cf613) into main (c000590) will decrease coverage by 0.01%.
The diff coverage is 36.66%.

❗ Current head 48cf613 differs from pull request most recent head 057d864. Consider uploading reports for the commit 057d864 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #824      +/-   ##
============================================
- Coverage     82.58%   82.56%   -0.02%     
  Complexity     1884     1884              
============================================
  Files           230      231       +1     
  Lines          4898     4899       +1     
============================================
  Hits           4045     4045              
- Misses          853      854       +1     
Flag Coverage Δ
7.4 82.57% <36.66%> (-0.02%) ⬇️
8.0 82.60% <36.66%> (-0.02%) ⬇️
8.1 82.60% <36.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/API/Trace/AbstractSpan.php 0.00% <0.00%> (ø)
src/API/Trace/NonRecordingSpan.php 100.00% <ø> (ø)
src/API/Trace/Span.php 0.00% <0.00%> (ø)
src/SDK/Trace/Span.php 94.23% <ø> (ø)
src/API/Trace/NoopSpanBuilder.php 100.00% <100.00%> (ø)
...c/API/Trace/Propagation/TraceContextPropagator.php 100.00% <100.00%> (ø)
src/Extension/Propagator/B3/B3MultiPropagator.php 100.00% <100.00%> (ø)
src/Extension/Propagator/B3/B3SinglePropagator.php 98.55% <100.00%> (ø)
src/SDK/Metrics/Exemplar/BucketStorage.php 100.00% <100.00%> (ø)
.../ExemplarFilter/WithSampledTraceExemplarFilter.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c000590...057d864. Read the comment docs.

Copy link
Collaborator

@brettmc brettmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you please add a BC compatibility entry for this one, as it's likely to break a lot of user code.

@Nevay Nevay force-pushed the feature/rename-abstract-span-to-span branch from 78d0ba7 to 057d864 Compare September 14, 2022 17:14
@brettmc brettmc merged commit 84142d3 into open-telemetry:main Sep 14, 2022
@Nevay Nevay deleted the feature/rename-abstract-span-to-span branch April 19, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants