Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add self-diagnostic metrics to BatchSpanProcessor #828

Conversation

Nevay
Copy link
Contributor

@Nevay Nevay commented Sep 18, 2022

No description provided.

@Nevay Nevay requested a review from a team as a code owner September 18, 2022 11:29
@codecov
Copy link

codecov bot commented Sep 18, 2022

Codecov Report

Merging #828 (7dd3d5a) into main (7940773) will decrease coverage by 0.98%.
The diff coverage is 43.06%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #828      +/-   ##
============================================
- Coverage     82.51%   81.52%   -0.99%     
- Complexity     1888     1925      +37     
============================================
  Files           234      239       +5     
  Lines          4908     5008     +100     
============================================
+ Hits           4050     4083      +33     
- Misses          858      925      +67     
Flag Coverage Δ
7.4 81.12% <32.16%> (-1.41%) ⬇️
8.0 81.58% <43.21%> (-0.97%) ⬇️
8.1 81.73% <45.26%> (-0.82%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Contrib/Otlp/MetricExporter.php 0.00% <0.00%> (ø)
src/Contrib/Otlp/ProtobufSerializer.php 0.00% <0.00%> (ø)
src/Contrib/Otlp/SpanExporter.php 0.00% <0.00%> (ø)
src/Contrib/OtlpHttp/MetricExporter.php 0.00% <0.00%> (ø)
src/SDK/Common/Export/Http/PsrTransportFactory.php 100.00% <ø> (ø)
src/SDK/Common/Export/Stream/StreamTransport.php 0.00% <0.00%> (ø)
...DK/Common/Export/Stream/StreamTransportFactory.php 0.00% <0.00%> (ø)
src/Contrib/Grpc/GrpcTransport.php 50.00% <33.33%> (-6.67%) ⬇️
...SDK/Common/Attribute/FilteredAttributesBuilder.php 56.52% <56.52%> (ø)
src/SDK/Common/Export/Http/PsrTransport.php 95.16% <60.00%> (-3.15%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3866a82...7dd3d5a. Read the comment docs.

@bobstrecansky
Copy link
Collaborator

@Nevay - this looks ready, just has a merge conflict that needs to be remediated.

@bobstrecansky bobstrecansky merged commit f73a835 into open-telemetry:main Oct 12, 2022
@Nevay Nevay deleted the feature/span-processor-self-diagnostics branch April 19, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants