Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fiber support not loaded in open-telemetry/context #829

Merged
merged 4 commits into from
Sep 19, 2022

Conversation

Nevay
Copy link
Contributor

@Nevay Nevay commented Sep 19, 2022

Adds missing autoload entry for initialize_fiber_handler.php and adds logging if OTEL_PHP_FIBERS_ENABLED is enabled and initialization of fiber support fails.

@Nevay Nevay requested a review from a team as a code owner September 19, 2022 12:58
@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Merging #829 (b6ff0a9) into main (deeb07a) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #829      +/-   ##
============================================
- Coverage     82.54%   82.46%   -0.09%     
- Complexity     1877     1878       +1     
============================================
  Files           230      230              
  Lines          4888     4893       +5     
============================================
  Hits           4035     4035              
- Misses          853      858       +5     
Flag Coverage Δ
7.4 82.47% <0.00%> (-0.09%) ⬇️
8.0 82.49% <0.00%> (-0.09%) ⬇️
8.1 82.49% <0.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Context/ZendObserverFiber.php 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update deeb07a...b6ff0a9. Read the comment docs.

@brettmc brettmc merged commit be3f88f into open-telemetry:main Sep 19, 2022
@Nevay Nevay deleted the fix/fiber-support-not-loaded branch April 19, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants