Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding OTEL_SDK_DISABLED support #833

Merged
merged 1 commit into from
Oct 7, 2022
Merged

adding OTEL_SDK_DISABLED support #833

merged 1 commit into from
Oct 7, 2022

Conversation

brettmc
Copy link
Collaborator

@brettmc brettmc commented Oct 3, 2022

@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Merging #833 (0cde756) into main (215731f) will decrease coverage by 0.05%.
The diff coverage is 60.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #833      +/-   ##
============================================
- Coverage     82.54%   82.49%   -0.06%     
- Complexity     1877     1883       +6     
============================================
  Files           232      234       +2     
  Lines          4893     4901       +8     
============================================
+ Hits           4039     4043       +4     
- Misses          854      858       +4     
Flag Coverage Δ
7.4 82.50% <60.00%> (-0.06%) ⬇️
8.0 82.52% <60.00%> (-0.06%) ⬇️
8.1 82.52% <60.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/SDK/Trace/NoopTracerProvider.php 0.00% <0.00%> (ø)
src/SDK/Metrics/MeterProvider.php 90.90% <100.00%> (ø)
src/SDK/SDK.php 100.00% <100.00%> (ø)
src/SDK/Trace/TracerProvider.php 100.00% <100.00%> (ø)
src/SDK/Trace/TracerProviderFactory.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 215731f...0cde756. Read the comment docs.

@brettmc brettmc marked this pull request as ready for review October 7, 2022 05:46
@brettmc brettmc requested a review from a team as a code owner October 7, 2022 05:46
@brettmc brettmc merged commit a3a47a6 into open-telemetry:main Oct 7, 2022
@brettmc brettmc deleted the otel_sdk_disabled branch October 25, 2022 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants