Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grpc metadata value must be an array #839

Merged
merged 1 commit into from
Oct 9, 2022
Merged

Conversation

leo108
Copy link
Contributor

@leo108 leo108 commented Oct 9, 2022

@leo108 leo108 requested a review from a team as a code owner October 9, 2022 16:27
@welcome
Copy link

welcome bot commented Oct 9, 2022

Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 9, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: leo108 / name: leo108 (dd15435)

@codecov
Copy link

codecov bot commented Oct 9, 2022

Codecov Report

Merging #839 (dd15435) into main (a3a47a6) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #839      +/-   ##
============================================
+ Coverage     82.49%   82.51%   +0.02%     
- Complexity     1883     1887       +4     
============================================
  Files           234      234              
  Lines          4901     4908       +7     
============================================
+ Hits           4043     4050       +7     
  Misses          858      858              
Flag Coverage Δ
7.4 82.52% <100.00%> (+0.02%) ⬆️
8.0 82.55% <100.00%> (+0.02%) ⬆️
8.1 82.55% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Contrib/OtlpGrpc/Exporter.php 92.00% <100.00%> (+0.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3a47a6...dd15435. Read the comment docs.

@brettmc
Copy link
Collaborator

brettmc commented Oct 9, 2022

Thanks for the fix, @leo108 .
I'm in the process of refactoring the otlp exporters, and I'll make sure this fix makes it across.

@brettmc brettmc merged commit 8562d0d into open-telemetry:main Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants