Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sdk builder #845

Merged
merged 5 commits into from
Oct 30, 2022
Merged

Sdk builder #845

merged 5 commits into from
Oct 30, 2022

Conversation

brettmc
Copy link
Collaborator

@brettmc brettmc commented Oct 17, 2022

Fluent SDK builder mechanism to create and configure a working SDK.

Closes #301

@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Merging #845 (7293011) into main (8798973) will decrease coverage by 0.79%.
The diff coverage is 40.81%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #845      +/-   ##
============================================
- Coverage     81.69%   80.90%   -0.80%     
- Complexity     1946     1973      +27     
============================================
  Files           241      246       +5     
  Lines          5080     5173      +93     
============================================
+ Hits           4150     4185      +35     
- Misses          930      988      +58     
Flag Coverage Δ
7.4 80.38% <40.81%> (-0.79%) ⬇️
8.0 80.89% <40.81%> (-0.80%) ⬇️
8.1 81.04% <40.81%> (-0.80%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/SDK/Metrics/MeterProviderBuilder.php 0.00% <0.00%> (ø)
src/SDK/Metrics/NoopMeterProvider.php 0.00% <0.00%> (ø)
.../Trace/SpanProcessor/BatchSpanProcessorBuilder.php 0.00% <0.00%> (ø)
src/SDK/Trace/TracerProviderBuilder.php 0.00% <0.00%> (ø)
src/SDK/Metrics/MeterProvider.php 86.95% <33.33%> (-3.96%) ⬇️
src/SDK/Trace/TracerProvider.php 92.30% <33.33%> (-7.70%) ⬇️
src/SDK/SdkBuilder.php 82.14% <82.14%> (ø)
src/SDK/Sdk.php 100.00% <100.00%> (ø)
src/SDK/Trace/TracerProviderFactory.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8798973...7293011. Read the comment docs.

@brettmc brettmc marked this pull request as ready for review October 25, 2022 02:22
@brettmc brettmc requested a review from a team as a code owner October 25, 2022 02:22
Copy link
Contributor

@tcarrio tcarrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly a vested citizen in the CNCF channel excited for the OTel PHP SDK. A couple things I noticed here that I thought I would comment on 🙂

src/SDK/Sdk.php Outdated Show resolved Hide resolved
src/SDK/Metrics/MeterProvider.php Outdated Show resolved Hide resolved
src/SDK/Trace/TracerProviderBuilder.php Outdated Show resolved Hide resolved
src/SDK/Trace/TracerProvider.php Outdated Show resolved Hide resolved
src/SDK/Trace/SpanProcessor/BatchSpanProcessorBuilder.php Outdated Show resolved Hide resolved
src/SDK/Trace/TracerProviderBuilder.php Show resolved Hide resolved
@brettmc brettmc merged commit ba98992 into open-telemetry:main Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration Interface and default configuration
4 participants