Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OTLP GRPC example #856

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Fix OTLP GRPC example #856

merged 1 commit into from
Nov 4, 2022

Conversation

erdemkose
Copy link
Contributor

OTLP GRPC example has a call to an unknown method.

@erdemkose erdemkose requested a review from a team as a code owner November 4, 2022 15:14
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 4, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: erdemkose / name: Erdem Köse (bcad2a8)

@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Merging #856 (141b49a) into main (0b43fac) will not change coverage.
The diff coverage is n/a.

❗ Current head 141b49a differs from pull request most recent head bcad2a8. Consider uploading reports for the commit bcad2a8 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #856   +/-   ##
=========================================
  Coverage     80.80%   80.80%           
  Complexity     1951     1951           
=========================================
  Files           248      248           
  Lines          5122     5122           
=========================================
  Hits           4139     4139           
  Misses          983      983           
Flag Coverage Δ
7.4 80.29% <ø> (ø)
8.0 80.80% <ø> (ø)
8.1 80.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b43fac...bcad2a8. Read the comment docs.

@brettmc brettmc merged commit 92e7a0d into open-telemetry:main Nov 4, 2022
@brettmc
Copy link
Collaborator

brettmc commented Nov 4, 2022

thanks @erdemkose !

@erdemkose erdemkose deleted the fix-otlp-grpc-example branch November 4, 2022 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants