Remove internal tag from Context::setStorage

[marcospassos]

Fixes #866

[welcome]

Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: marcospassos / name: Marcos Passos (418ec81)

[brettmc]

Hi @marcospassos I haven't worked on context in very much depth, can you elaborate on your use-case for needing custom context storage?

[marcospassos]

Sure! We've been using the Swoole context for some time now, and it works perfectly. But the only way to use it is by setting it through Context::setStorage (e.g., integrating with the Swoole storage). However, this method is flagged as internal, but it doesn't make much sense since there is no other way of specifying custom contexts.

[codecov]

Codecov Report

Merging #867 (418ec81) into main (904da75) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff            @@
##               main     #867   +/-   ##
=========================================
  Coverage     79.81%   79.81%           
  Complexity     2035     2035           
=========================================
  Files           268      268           
  Lines          5271     5271           
=========================================
  Hits           4207     4207           
  Misses         1064     1064           

Flag	Coverage Δ
7.4	79.30% <ø> (ø)
8.0	79.80% <ø> (ø)
8.1	79.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/Context/Context.php	82.05% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 904da75...418ec81. Read the comment docs.

[brettmc]

That makes sense, @marcospassos - I don't see any other way to do it. Can you please sign the CLA so that we can accept your work?
And, since you're using the library, we'd love your feedback on whether there's an easier way for others to use this module. For example, we could hook into composer's autoloader and have it set the default context storage automatically (maybe enabled by a config/env var) - I don't know whether that's viable with swoole or not, but we're trying to reduce/eliminate setup code for users.

[marcospassos]

Can you please sign the CLA so that we can accept your work?

Done!

[omigafu]

Sure! We've been using the Swoole context for some time now, and it works perfectly. But the only way to use it is by setting it through Context::setStorage (e.g., integrating with the Swoole storage). However, this method is flagged as internal, but it doesn't make much sense since there is no other way of specifying custom contexts.

@marcospassos Can you provide a more detailed example? I need a concrete demo because I don't have a deep research on this, thanks!