allow 16 char b3 trace id #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b3 spec allows trace id to be 16 or 32 char. other SIGs left-pad with zero to resolve this.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #869 +/- ##
============================================
- Coverage 81.24% 81.21% -0.03%
- Complexity 2006 2008 +2
============================================
Files 264 264
Lines 5208 5212 +4
============================================
+ Hits 4231 4233 +2
- Misses 977 979 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Nevay
approved these changes
Nov 29, 2022
bobstrecansky
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b3 spec allows trace id to be 16 or 32 char. other SIGs left-pad with zero to resolve this.
Closes #863