Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disallow non-standard boolean config values #870

Merged
merged 1 commit into from
Nov 29, 2022
Merged

disallow non-standard boolean config values #870

merged 1 commit into from
Nov 29, 2022

Conversation

brettmc
Copy link
Collaborator

@brettmc brettmc commented Nov 25, 2022

per spec, only 'true' and 'false' are valid boolean values. anything else should be interpreted as false and a warning emitted.

Closes #861

per spec, only 'true', 'false' are valid boolean values. anything else should be
interpreted as false and a warning emitted.
@brettmc brettmc requested a review from a team as a code owner November 25, 2022 02:40
@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Merging #870 (5f4753e) into main (904da75) will decrease coverage by 0.08%.
The diff coverage is 70.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #870      +/-   ##
============================================
- Coverage     79.81%   79.73%   -0.09%     
- Complexity     2035     2036       +1     
============================================
  Files           268      268              
  Lines          5271     5274       +3     
============================================
- Hits           4207     4205       -2     
- Misses         1064     1069       +5     
Flag Coverage Δ
7.4 79.22% <70.00%> (-0.09%) ⬇️
8.0 79.72% <70.00%> (-0.09%) ⬇️
8.1 79.86% <70.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/SDK/Common/Configuration/Configuration.php 95.23% <62.50%> (-4.77%) ⬇️
.../SDK/Common/Configuration/Parser/BooleanParser.php 88.88% <100.00%> (ø)
src/SDK/SdkAutoloader.php 34.78% <0.00%> (-8.70%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 904da75...5f4753e. Read the comment docs.

@brettmc brettmc merged commit 01378ec into open-telemetry:main Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

boolean config values
2 participants