Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decode OTEL_RESOURCE_ATTRIBUTES values #872

Merged
merged 2 commits into from
Nov 29, 2022
Merged

decode OTEL_RESOURCE_ATTRIBUTES values #872

merged 2 commits into from
Nov 29, 2022

Conversation

brettmc
Copy link
Collaborator

@brettmc brettmc commented Nov 27, 2022

per spec, resource attributes coming from environment should be decoded in the same way that they would be if coming from a header

Closes #786

per spec, resource attributes coming from environment should be decoded in
the same way that they would be if coming from a header
@brettmc brettmc requested a review from a team as a code owner November 27, 2022 23:14
@codecov
Copy link

codecov bot commented Nov 27, 2022

Codecov Report

Merging #872 (888e298) into main (904da75) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 888e298 differs from pull request most recent head 0802700. Consider uploading reports for the commit 0802700 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #872   +/-   ##
=========================================
  Coverage     79.81%   79.82%           
- Complexity     2035     2036    +1     
=========================================
  Files           268      268           
  Lines          5271     5273    +2     
=========================================
+ Hits           4207     4209    +2     
  Misses         1064     1064           
Flag Coverage Δ
7.4 79.31% <100.00%> (+<0.01%) ⬆️
8.0 79.81% <100.00%> (+<0.01%) ⬆️
8.1 79.95% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Context/Context.php 82.05% <ø> (ø)
src/SDK/Resource/Detectors/Environment.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 904da75...0802700. Read the comment docs.

@brettmc brettmc merged commit d37d449 into open-telemetry:main Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decode values from OTEL_RESOURCE_ATTRIBUTES
3 participants