Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run exports with the Context the SpanProcessor was created in #880

Conversation

Nevay
Copy link
Contributor

@Nevay Nevay commented Dec 1, 2022

Resolves #878.

(Matches the behavior of async implementations that create the export fiber in the constructor, example).

@brettmc
Copy link
Collaborator

brettmc commented Dec 2, 2022

I tested this out, it works for me - exporter requests are no longer instrumented. I can see that the instrumentation handler pre function now gets a no-op tracer when handling exporting requests.

@Nevay Nevay marked this pull request as ready for review December 2, 2022 13:46
@Nevay Nevay requested a review from a team as a code owner December 2, 2022 13:46
@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Merging #880 (98c8bfa) into main (0ce2fda) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #880      +/-   ##
============================================
+ Coverage     81.21%   81.23%   +0.02%     
  Complexity     2008     2008              
============================================
  Files           264      264              
  Lines          5212     5218       +6     
============================================
+ Hits           4233     4239       +6     
  Misses          979      979              
Flag Coverage Δ
7.4 80.72% <100.00%> (+0.02%) ⬆️
8.0 81.22% <100.00%> (+0.02%) ⬆️
8.1 81.36% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/SDK/Trace/SpanProcessor/BatchSpanProcessor.php 100.00% <100.00%> (ø)
...rc/SDK/Trace/SpanProcessor/SimpleSpanProcessor.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ce2fda...98c8bfa. Read the comment docs.

@bobstrecansky bobstrecansky merged commit fd8ac30 into open-telemetry:main Dec 2, 2022
@Nevay Nevay deleted the fix/export-run-in-construction-context branch April 19, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

contrib psr18 auto-instrumentation also instruments exporter
3 participants