Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix stream transport factory creation #882

Merged
merged 4 commits into from
Dec 5, 2022
Merged

fix stream transport factory creation #882

merged 4 commits into from
Dec 5, 2022

Conversation

brettmc
Copy link
Collaborator

@brettmc brettmc commented Dec 5, 2022

when creating a stream from an endpoint string, the factory wasn't returning the stream. fix and add tests.

when creating a stream from an endpoint string, the factory wasn't returning the stream. fix and add tests.
@brettmc brettmc requested a review from a team as a code owner December 5, 2022 05:37
@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Merging #882 (6caef34) into main (0ce2fda) will increase coverage by 0.35%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #882      +/-   ##
============================================
+ Coverage     81.21%   81.56%   +0.35%     
  Complexity     2008     2008              
============================================
  Files           264      264              
  Lines          5212     5219       +7     
============================================
+ Hits           4233     4257      +24     
+ Misses          979      962      -17     
Flag Coverage Δ
7.4 81.05% <100.00%> (+0.35%) ⬆️
8.0 81.55% <100.00%> (+0.35%) ⬆️
8.1 81.69% <100.00%> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...DK/Common/Export/Stream/StreamTransportFactory.php 81.81% <100.00%> (+81.81%) ⬆️
src/SDK/Trace/SpanProcessor/BatchSpanProcessor.php 100.00% <100.00%> (ø)
...rc/SDK/Trace/SpanProcessor/SimpleSpanProcessor.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd8ac30...6caef34. Read the comment docs.

@brettmc brettmc merged commit 587bc5a into open-telemetry:main Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants