Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move/cleanup exporter examples #886

Merged
merged 1 commit into from
Dec 6, 2022
Merged

move/cleanup exporter examples #886

merged 1 commit into from
Dec 6, 2022

Conversation

brettmc
Copy link
Collaborator

@brettmc brettmc commented Dec 6, 2022

  • moving exporter examples up one directory, where I think they are more obvious to find
  • remove some old and broken grpc examples
  • remove unused interface

moving exporter examples up one directory, where I think they are more obvious to find.
remove some old and broken grpc examples.
remove unused interface.
@brettmc brettmc requested a review from a team as a code owner December 6, 2022 04:55
@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #886 (b7a6f17) into main (587bc5a) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #886   +/-   ##
=========================================
  Coverage     81.56%   81.56%           
  Complexity     2008     2008           
=========================================
  Files           264      264           
  Lines          5219     5219           
=========================================
  Hits           4257     4257           
  Misses          962      962           
Flag Coverage Δ
7.4 81.05% <ø> (ø)
8.0 81.55% <ø> (ø)
8.1 81.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 587bc5a...b7a6f17. Read the comment docs.

@pdelewski
Copy link
Member

pdelewski commented Dec 6, 2022

Seems that features is a container for examples that do not belongs to any other category

@brettmc brettmc merged commit a1e8aff into open-telemetry:main Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants