Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing default service name #887

Merged
merged 2 commits into from
Dec 6, 2022
Merged

fixing default service name #887

merged 2 commits into from
Dec 6, 2022

Conversation

brettmc
Copy link
Collaborator

@brettmc brettmc commented Dec 6, 2022

default service name should contain runtime name if available: java just appends ":java" so I did the same.
ref: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/resource/semantic_conventions/README.md#service

- default service name should contain runtime name if available: java just appends ":java" so I did the same
@brettmc brettmc requested a review from a team as a code owner December 6, 2022 05:06
@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #887 (29631d4) into main (587bc5a) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #887   +/-   ##
=========================================
  Coverage     81.56%   81.56%           
  Complexity     2008     2008           
=========================================
  Files           264      264           
  Lines          5219     5219           
=========================================
  Hits           4257     4257           
  Misses          962      962           
Flag Coverage Δ
7.4 81.05% <ø> (ø)
8.0 81.55% <ø> (ø)
8.1 81.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/SDK/Resource/Detectors/SdkProvided.php 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 587bc5a...29631d4. Read the comment docs.

@pdelewski
Copy link
Member

default service name should contain runtime name if available: java just appends ":java" so I did the same.

Interesting, I was thinking that this requires something more sophisticated :)

Co-authored-by: Tobias Bachert <git@b-privat.de>
@brettmc brettmc merged commit 311afa2 into open-telemetry:main Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants