Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding baggage setValue and removeValue, plus example usage #888

Merged
merged 4 commits into from
Dec 6, 2022
Merged

adding baggage setValue and removeValue, plus example usage #888

merged 4 commits into from
Dec 6, 2022

Conversation

brettmc
Copy link
Collaborator

@brettmc brettmc commented Dec 6, 2022

@brettmc brettmc requested a review from a team as a code owner December 6, 2022 07:04
@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #888 (74ef563) into main (587bc5a) will not change coverage.
The diff coverage is n/a.

❗ Current head 74ef563 differs from pull request most recent head 4ba14b0. Consider uploading reports for the commit 4ba14b0 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #888   +/-   ##
=========================================
  Coverage     81.56%   81.56%           
  Complexity     2008     2008           
=========================================
  Files           264      264           
  Lines          5219     5219           
=========================================
  Hits           4257     4257           
  Misses          962      962           
Flag Coverage Δ
7.4 81.05% <ø> (ø)
8.0 81.55% <ø> (ø)
8.1 81.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 587bc5a...4ba14b0. Read the comment docs.

@Nevay
Copy link
Contributor

Nevay commented Dec 6, 2022

I don't think we need this - functionality is already available via ::toBuilder().

@pdelewski
Copy link
Member

I don't think we need this - functionality is already available via ::toBuilder().

Seems you are right as specification gives some freedom how and where this functionality has to be provided.

Depending on language idioms, a language API MAY implement these functions by using a Builder pattern and exposing a way to construct a Builder from a Baggage

toBaggageBuilder() can be used to achieve this, so update the example to do this
@brettmc brettmc merged commit dc5ef24 into open-telemetry:main Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants