Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move LoggerHolder to API #893

Merged
merged 2 commits into from
Dec 11, 2022
Merged

move LoggerHolder to API #893

merged 2 commits into from
Dec 11, 2022

Conversation

brettmc
Copy link
Collaborator

@brettmc brettmc commented Dec 9, 2022

there is a requirement (and some outstanding todo's) to log errors and warnings from the API, so move logger setup into API to facilitate this.

Closes #889
Replaces #891

there is a requirement (and some outstanding todo's) to log errors and warnings from the API, so move
logger setup into API to facilitate this.
@brettmc brettmc requested a review from a team as a code owner December 9, 2022 04:19
@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Merging #893 (808c58e) into main (5a51249) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #893   +/-   ##
=========================================
  Coverage     81.12%   81.12%           
  Complexity     1907     1907           
=========================================
  Files           252      252           
  Lines          4933     4933           
=========================================
  Hits           4002     4002           
  Misses          931      931           
Flag Coverage Δ
7.4 80.57% <ø> (ø)
8.0 81.10% <ø> (ø)
8.1 81.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/API/Behavior/LogsMessagesTrait.php 100.00% <ø> (ø)
src/API/Common/Log/LoggerHolder.php 100.00% <ø> (ø)
src/Contrib/Grpc/GrpcTransportFactory.php 52.27% <ø> (ø)
src/Contrib/Newrelic/Exporter.php 100.00% <ø> (ø)
src/Contrib/Otlp/MetricExporter.php 38.70% <ø> (ø)
src/Contrib/Otlp/SpanExporter.php 77.77% <ø> (ø)
src/Contrib/Otlp/SpanExporterFactory.php 100.00% <ø> (ø)
src/Contrib/Zipkin/Exporter.php 100.00% <ø> (ø)
src/Contrib/ZipkinToNewrelic/Exporter.php 85.00% <ø> (ø)
src/SDK/Common/Configuration/Configuration.php 95.23% <ø> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a51249...808c58e. Read the comment docs.

@brettmc brettmc merged commit 602ea85 into open-telemetry:main Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make logging available from API
2 participants